Target frameworks not matching #229
Conversation
Nuget.Frameworks started returning DotNetFrameworkName as "net5.0" which is what vstest will pass down as the target framework name. There is some guidance how to do that better, but this is a quick fix to be able to run xUnit tests on net5.0-preview8 and newer, before we figure out the best way to do this.
|
@bradwilson could you merge this please and release a new version so we can use it in dotnet templates? I know the fix is version specific and will break when we have net6.x, but that gives us a lot of time to fix this properly. |
|
I'll merge and get this out as 2.4.3, but I'll hold you to a proper fix ;) |
|
2.4.3 is live with this fix https://www.nuget.org/packages/xunit.runner.visualstudio/2.4.3 |
| @@ -113,7 +113,8 @@ public bool IsMatchingTargetFramework() | |||
|
|
|||
| #if NETCOREAPP | |||
| return string.IsNullOrWhiteSpace(TargetFrameworkVersion) ||// Short circuit on null since we don't have anything to detect, return true | |||
| (TargetFrameworkVersion.StartsWith(".NETCoreApp,", StringComparison.OrdinalIgnoreCase) || | |||
| (TargetFrameworkVersion.StartsWith("net5", StringComparison.OrdinalIgnoreCase) || | |||
There was a problem hiding this comment.
What about net6? We will soon branch to it.
There was a problem hiding this comment.
You should have a follow up to fix this properly.
There was a problem hiding this comment.
@nkolev92 what is the correct fix for this?
There was a problem hiding this comment.
Copying my comment from the internal e-mail thread:
I think the guidance would be to never depend on the short name, or anything NuGet generated, but depend on the TFI/TFV.
If you ever have the NuGetFramework type, use the `Framework` property.
Let's not the same mistake as NuGet that caused: NuGet/Home#5154 :)
There was a problem hiding this comment.
Though to be fair, this value is not the TFM the user uses. It is the evaluated MSBuild property.
There was a problem hiding this comment.
yeah, I'm not 100% familiar with the code here, but the general rule is to use props like TFI etc.
We probably have other places in the stack where this is being done, so we should do our best to weed them out.
There was a problem hiding this comment.
Was responding to Viktor, the UI did not update for me: Then I need to fix this faster, or add another condition to this if, and to the two ifs that are in vstest that match runtime providers.
Using the 2.4.1 version of the runner fails with "Make sure that test discoverer & executors are registered and platform & framework version settings are appropriate and try again." when executing `dotnet test` on .NET 5 project. 2,4,3 was specifically released to address this. See xunit/visualstudio.xunit#229.
* Use Xunit runner that is compatible with .NET 5 Using the 2.4.1 version of the runner fails with "Make sure that test discoverer & executors are registered and platform & framework version settings are appropriate and try again." when executing `dotnet test` on .NET 5 project. 2,4,3 was specifically released to address this. See xunit/visualstudio.xunit#229.
Nuget.Frameworks started returning DotNetFrameworkName as "net5.0"
which is what vstest will pass down as the target framework name.
There is some guidance how to do that better, but this is a quick fix
to be able to run xUnit tests on net5.0-preview8 and newer, before we
figure out the best way to do this.