Explicitly use latest Microsoft.CodeAnalysis.Analyzers per @sharwell

xunit · Jun 5, 2024 · 70f5c6c · 70f5c6c
1 parent 4124038
commit 70f5c6c
Show file tree

Hide file tree

Showing 8 changed files with 1 addition and 15 deletions.
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -28,6 +28,7 @@
   </ItemGroup>
 
   <ItemGroup>
+    <PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="3.11.0-beta1.24219.2" />
     <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="[$(MicrosoftCodeAnalysisVersion)]" />
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="all" />
     <PackageReference Include="Nerdbank.GitVersioning" Version="3.6.139">

diff --git a/src/xunit.analyzers/Utility/CodeAnalysisExtensions.cs b/src/xunit.analyzers/Utility/CodeAnalysisExtensions.cs
@@ -27,10 +27,7 @@ public static ImmutableArray<AttributeData> GetAttributesWithInheritance(
 		this IMethodSymbol method,
 		ITypeSymbol? attributeUsageType)
 	{
-#pragma warning disable RS1024 // This is correct usage
 		var result = new Dictionary<INamedTypeSymbol, List<AttributeData>>(SymbolEqualityComparer.Default);
-#pragma warning restore RS1024
-
 		foreach (var attribute in method.GetAttributes())
 			if (attribute.AttributeClass is not null)
 				result.Add(attribute.AttributeClass, attribute);

diff --git a/src/xunit.analyzers/X1000/DoNotUseBlockingTaskOperations.cs b/src/xunit.analyzers/X1000/DoNotUseBlockingTaskOperations.cs
@@ -1,5 +1,3 @@
-#pragma warning disable RS1024 // Incorrectly triggered by Roslyn 3.11
-
 using System;
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;

diff --git a/src/xunit.analyzers/X1000/EnsureFixturesHaveASource.cs b/src/xunit.analyzers/X1000/EnsureFixturesHaveASource.cs
@@ -1,5 +1,3 @@
-#pragma warning disable RS1024 // Incorrectly triggered by Roslyn 3.11
-
 using System.Collections.Generic;
 using System.Collections.Immutable;
 using System.Linq;

diff --git a/src/xunit.analyzers/X1000/TestMethodCannotHaveOverloads.cs b/src/xunit.analyzers/X1000/TestMethodCannotHaveOverloads.cs
@@ -1,5 +1,3 @@
-#pragma warning disable RS1024 // Incorrectly triggered by Roslyn 3.11
-
 using System.Collections.Generic;
 using System.Linq;
 using Microsoft.CodeAnalysis;

diff --git a/src/xunit.analyzers/X1000/TestMethodMustNotHaveMultipleFactAttributes.cs b/src/xunit.analyzers/X1000/TestMethodMustNotHaveMultipleFactAttributes.cs
@@ -1,5 +1,3 @@
-#pragma warning disable RS1024 // Incorrectly triggered by Roslyn 3.11
-
 using System.Collections.Generic;
 using System.Collections.Immutable;
 using System.Linq;

diff --git a/src/xunit.analyzers/X1000/TheoryMethodShouldUseAllParameters.cs b/src/xunit.analyzers/X1000/TheoryMethodShouldUseAllParameters.cs
@@ -1,5 +1,3 @@
-#pragma warning disable RS1024 // Incorrectly triggered by Roslyn 3.11
-
 using System.Collections.Generic;
 using System.Linq;
 using System.Text.RegularExpressions;

diff --git a/src/xunit.analyzers/X2000/SetEqualityAnalyzer.cs b/src/xunit.analyzers/X2000/SetEqualityAnalyzer.cs
@@ -1,5 +1,3 @@
-#pragma warning disable RS1024 // Incorrectly triggered by Roslyn 3.11
-
 using System.Collections.Generic;
 using System.Linq;
 using Microsoft.CodeAnalysis;