Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rewrote module #21

Merged
merged 23 commits into from
May 30, 2020
Merged

feat: rewrote module #21

merged 23 commits into from
May 30, 2020

Conversation

xunleii
Copy link
Owner

@xunleii xunleii commented May 30, 2020

This module was rewrote in full TF 12 in order to:

  • fix issues like Server taints flags are not used #20
  • add multi master
  • add better management of annotations, labels and taints
  • add better UX (no more required value and input validation)

@github-actions
Copy link
Contributor

terraform fmt Failed

examples/hcloud-k3s/k3s.tf
     pods     = "10.42.0.0/16"
     services = "10.43.0.0/16"
   }
-  drain_timeout = "30s"
+  drain_timeout  = "30s"
   managed_fields = ["label", "taint"] // ignore annotations
 
   global_flags = [

Workflow: Terraform GitHub Actions, Action: hashicorpterraform-github-actions1, Working Directory: examples/hcloud-k3s, Workspace: default

@github-actions
Copy link
Contributor

terraform init Failed

Initializing modules...
- k3s in ../..
There are some problems with the configuration, described below.

The Terraform configuration must be valid before initialization so that
Terraform can determine which modules and providers need to be installed.

Error: Unsupported argument

  on ../../main.tf line 3, in terraform:
   3:   experiments      = [variable_validation]

An argument named "experiments" is not expected here.


Error: Unsupported block type

  on ../../variables.tf line 46, in variable "servers":
  46:   validation {

Blocks of type "validation" are not expected here.


Error: Unsupported block type

  on ../../variables.tf line 50, in variable "servers":
  50:   validation {

Blocks of type "validation" are not expected here.


Error: Unsupported block type

  on ../../variables.tf line 54, in variable "servers":
  54:   validation {

Blocks of type "validation" are not expected here.


Error: Unsupported block type

  on ../../variables.tf line 58, in variable "servers":
  58:   validation {

Blocks of type "validation" are not expected here.


Error: Unsupported block type

  on ../../variables.tf line 62, in variable "servers":
  62:   validation {

Blocks of type "validation" are not expected here.


Error: Unsupported block type

  on ../../variables.tf line 66, in variable "servers":
  66:   validation {

Blocks of type "validation" are not expected here.


Error: Unsupported block type

  on ../../variables.tf line 70, in variable "servers":
  70:   validation {

Blocks of type "validation" are not expected here.


Error: Unsupported block type

  on ../../variables.tf line 74, in variable "servers":
  74:   validation {

Blocks of type "validation" are not expected here.


Error: Unsupported block type

  on ../../variables.tf line 85, in variable "agents":
  85:   validation {

Blocks of type "validation" are not expected here.


Error: Unsupported block type

  on ../../variables.tf line 89, in variable "agents":
  89:   validation {

Blocks of type "validation" are not expected here.


Error: Unsupported block type

  on ../../variables.tf line 93, in variable "agents":
  93:   validation {

Blocks of type "validation" are not expected here.


Error: Unsupported block type

  on ../../variables.tf line 97, in variable "agents":
  97:   validation {

Blocks of type "validation" are not expected here.


Error: Unsupported block type

  on ../../variables.tf line 101, in variable "agents":
 101:   validation {

Blocks of type "validation" are not expected here.


Error: Unsupported block type

  on ../../variables.tf line 105, in variable "agents":
 105:   validation {

Blocks of type "validation" are not expected here.

Workflow: Terraform GitHub Actions, Action: hashicorpterraform-github-actions2, Working Directory: examples/hcloud-k3s, Workspace: default

@xunleii xunleii force-pushed the feat-rewrote-module branch 2 times, most recently from 4bb3744 to 31e5032 Compare May 30, 2020 21:43
@xunleii xunleii merged commit e0292b5 into master May 30, 2020
@xunleii xunleii deleted the feat-rewrote-module branch May 30, 2020 21:58
@xunleii xunleii restored the feat-rewrote-module branch May 31, 2020 16:45
@xunleii xunleii deleted the feat-rewrote-module branch May 31, 2020 16:45
@tedsteen
Copy link
Contributor

tedsteen commented Jun 1, 2020

Wow! Very nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants