-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate Kubeconfig file #37
Conversation
Thanks for your PR. However, I have some requests to validate it:
Thanks a lot and good Hacktoberfest 😄 |
Yes, I can make the certificate generation optional, but it will be impossible to generate the kubeconfig file. Nowadays it´s alredy impossible to skip cerificate generation (K3S installer generate the ca certificates in the host machine). So, we are not loosing anything ... With that said, I can make a paremeter so users can pass the own certificates instead of generation it. What do you think? |
We are loosing some default configuration defined by the Rancher team about their certificates, that is why I would like to have the option to enable (or disable) this feature. But, of course, we will loose the ability to get the Kubeconfig (which is a great improvement for this module).
Yep, that could be awesome too 👍 |
Ok, I will do that! But probably on the weekend |
@xunleii I finished what you asked for, can you take a look please? |
LGTM, thanks a lot for your work ! |
This PR add support for: