Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Kubeconfig file #37

Merged
merged 10 commits into from
Oct 1, 2020
Merged

Generate Kubeconfig file #37

merged 10 commits into from
Oct 1, 2020

Conversation

guitcastro
Copy link
Contributor

This PR add support for:

  • Use custom CA certificates
  • Generate the KubeConfig based on those previously generated certificates
  • kubeconfig and kubernetes output
  • A Civo example

@xunleii
Copy link
Owner

xunleii commented Sep 28, 2020

Thanks for your PR. However, I have some requests to validate it:

  • Can you make auto-generated certificate optional ? (ofc, if this option is disable, the Kubeconfig cannot be generated)
  • Can you "variabalize" a bit the certificate generation (eg. CA validity, algorithm, ... with default values) ?

Thanks a lot and good Hacktoberfest 😄

@guitcastro
Copy link
Contributor Author

Yes, I can make the certificate generation optional, but it will be impossible to generate the kubeconfig file. Nowadays it´s alredy impossible to skip cerificate generation (K3S installer generate the ca certificates in the host machine). So, we are not loosing anything ...

With that said, I can make a paremeter so users can pass the own certificates instead of generation it. What do you think?

@xunleii
Copy link
Owner

xunleii commented Sep 28, 2020

Yes, I can make the certificate generation optional, but it will be impossible to generate the kubeconfig file. Nowadays it´s alredy impossible to skip cerificate generation (K3S installer generate the ca certificates in the host machine). So, we are not loosing anything ...

We are loosing some default configuration defined by the Rancher team about their certificates, that is why I would like to have the option to enable (or disable) this feature. But, of course, we will loose the ability to get the Kubeconfig (which is a great improvement for this module).

With that said, I can make a paremeter so users can pass the own certificates instead of generation it. What do you think?

Yep, that could be awesome too 👍

@guitcastro
Copy link
Contributor Author

Ok, I will do that! But probably on the weekend

@guitcastro
Copy link
Contributor Author

@xunleii I finished what you asked for, can you take a look please?

@xunleii
Copy link
Owner

xunleii commented Oct 1, 2020

LGTM, thanks a lot for your work !

@xunleii xunleii merged commit 23ab2ff into xunleii:master Oct 1, 2020
@xunleii xunleii added this to the v2.2.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants