Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow bypassing openPage() #2

Closed
Roguelazer opened this issue Dec 15, 2016 · 1 comment
Closed

Allow bypassing openPage() #2

Roguelazer opened this issue Dec 15, 2016 · 1 comment
Labels
enhancement

Comments

@Roguelazer
Copy link

On launch, aurora attempts to open a browser in the openPage function. This really only makes sense in testing, and shouldn't be attempted by default.

This also doesn't work if you're binding to a wildcard (e.g., to 0.0.0.0 or [::])
xuri added a commit that referenced this issue Dec 18, 2016
@xuri
- Upgrade version to 1.7;
27e2a68 
- Bugfix Do not force config path to be relative to binary location (issue #1);
- Add `openpage` section to config file, if set `enabled = false` will not automatically open the browser (related issue #2);
- Sort tube names by alphabetically resolve issue #3;
@xuri
Copy link
Owner

xuri commented Dec 18, 2016

@Roguelazer Thanks for your issue. I have added a openpage section in config file, if set enabled = false will not automatically open the browser. Note that we need to set the port for listening address, use 0.0.0.0:80 instead of 0.0.0.0.

@xuri xuri closed this as completed Dec 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Roguelazer @xuri