Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mg-100-starfortress-sf-17.json #159

Merged
merged 1 commit into from Dec 21, 2018
Merged

Update mg-100-starfortress-sf-17.json #159

merged 1 commit into from Dec 21, 2018

Conversation

ghost
Copy link

@ghost ghost commented Dec 20, 2018

Make this name match the card (might wanna rename this file to match)

Make this name match the card (might wanna rename this file to match)
@Mu0n
Copy link
Collaborator

Mu0n commented Dec 20, 2018

Warning: a JSON prefix file name change would have 2 consequences:
Minor: the manifest has to be updated and everything that uses it must adapt
Less minor: while vassal will be able to dynamically see the new manifest and adjust its internal squad builder without skipping a beat, it won't have the corresponding gfx file names and will spawn WIP images for the ship base and all its pilot cards. It's doable, but is it necessary?

@ghost
Copy link
Author

ghost commented Dec 20, 2018

I dont really care about the filename - i just suggested the change to match the ship name. The card does not have the ‘-sf-17’ at the end of its name. Where did that come from? Does the name in their squad builder have it?

@philipdouglas
Copy link
Collaborator

Where did that come from?

I think it was a guess from when they first announced the Resistance and we didn't know for sure what it would be called in 2.0, because it's the full name used on Wookieepedia.

@philipdouglas philipdouglas merged commit e276d7d into xwingtmg:master Dec 21, 2018
guidokessels added a commit that referenced this pull request Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants