Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing Sabine Wren (Command) #690

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

J1mBob
Copy link
Contributor

@J1mBob J1mBob commented Jul 7, 2024

No description provided.

@J1mBob
Copy link
Contributor Author

J1mBob commented Jul 7, 2024

Not sure why the faction restriction of "Rebel Alliance" is failing.

@awsaba
Copy link

awsaba commented Jul 7, 2024

Not sure why the faction restriction of "Rebel Alliance" is failing.

@J1mBob That restriction is using the the XWS, it is working here: https://github.com/xwingtmg/xwing-data2/pull/688/files#diff-f5f86c9ce238cb0c1deb78b42d303f3c74adea729720b84bc9f08ffdd9f9e93cR636

@awsaba
Copy link

awsaba commented Jul 7, 2024

@J1mBob FYI I submitted #688 a few a weeks ago to add this and it is passing the tests if you want something to compare it to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants