Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent inserting empty meta values, fix #1080 #1307

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Prevent inserting empty meta values, fix #1080 #1307

merged 1 commit into from
Mar 8, 2022

Conversation

lkraav
Copy link
Contributor

@lkraav lkraav commented Feb 20, 2022

Fixes #1080 .

Describe your approach and how it fixes the issue.

Checklist

  • Project documentation has been updated to reflect the changes in this pull request, if applicable.
  • I have tested the changes in the local development environment (see contributing.md).
  • I have added phpunit tests.

Release Changelog

  • Fix: Prevent inserting empty meta values database bloat.

@kasparsd kasparsd merged commit 450eded into xwp:develop Mar 8, 2022
@lkraav lkraav deleted the 1080-prevent-empty-meta branch March 8, 2022 10:04
@lkraav
Copy link
Contributor Author

lkraav commented Mar 8, 2022

Ideally we'd have some tests, but... not enough energy right now. Maybe later.

@kasparsd kasparsd mentioned this pull request Mar 8, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasparsd kasparsd kasparsd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3.4.3: prevent DB_Driver_WPDB::insert_record() from inserting empty meta values
2 participants
@lkraav @kasparsd