-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deps and WPCS before release #1309
Conversation
kasparsd
commented
Mar 8, 2022
•
edited
Loading
edited
- Update Node and Composer deps.
- WPCS formatting prior release.
- Switch to MariaDB containers to make it compatible with ARM Macs.
Looks like #1264 made one of the unit tests for EDD fail:
stream/tests/tests/connectors/test-class-connector-edd.php Lines 172 to 193 in 305583d
I'm not sure why the |
@@ -18,9 +18,6 @@ public function setUp() { | |||
|
|||
$this->plugin->connectors->unload_connectors(); | |||
|
|||
$post_connector = new Connector_Posts(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was causing the wp_stream_log_data
action to be called twice -- once for the EDD connector and once for the Posts connector and the test in this file was being run during both.