Fixup fc606db #1312
Open
Fixup fc606db #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparsd
reviewed
Aug 23, 2022
| // | ||
| // @see https://www.php.net/manual/en/function.array-filter.php#111091 | ||
| $stream_meta = array_filter( $args, 'strlen' ); | ||
| $user_meta = array_filter( $user_meta, 'strlen' ); |
There was a problem hiding this comment.
@lkraav Were you able to confirm that this works with the nested $user_meta array?
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit fc606db.
We found a more correct location to improve a previously existing sanity check.
Fixes #1080, but better. Sorry @kasparsd 😄
You were right, there was a connection between #1038 and #1080 all along. I now traced down how all meta is added to a record, and found we're already trying to prevent empty values. Unfortunately
$stream_meta is_null()check alone is weak$user_metabeing a nested array, its actual contents isn't checked at allstrlentrick seems to be a solid one, considering hundreds of upvotes on PHP docs. I always disliked having to do a separate empty string check foris_scalar()result.Now that previous version is in, this PR doesn't have urgency for its own release.