Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream Alerts Alpha #844

Merged
merged 237 commits into from
Oct 31, 2016
Merged

Stream Alerts Alpha #844

merged 237 commits into from
Oct 31, 2016

Conversation

tylerhcarter
Copy link
Contributor

@tylerhcarter tylerhcarter commented Apr 19, 2016 •
edited by lukecarbis
Loading

With a good amount of the work laid out, it is time to start honing in on the final prototype and what needs to get done. Here's a basic list:

Core Functionality

  • Allow notifiers to display/save form information
  • Add unit tests to test all core API functionality
  • Allow users to active and deactivate alerts (post_status?)

User Interface

  • Polish 'Edit Alert' page CSS/HTML.
  • Make sure all quick edit information is relevant.
  • Tweak Publish Box to only display relevant entries

Alert Types

  • Finish Email Message Implementation
  • Add Highlight Notifier
  • Add Emailer Notifier
  • Add IFTTT Notifier

Bugs

  • Alerts list cannot be seen on Network Admin
  • Status missing from Alerts list table
  • Default states of Trigger dropdowns is wrong (should be the same as Exclude Rules)
  • Clearing the Trigger dropdowns gives a javascript error and doesn't work
  • Currently active option should default to enabled
  • Remove hover state actions in the "matched records" section
  • Highlights can't be cleared
  • "Records matching these features" does not update automatically

Luke Carbis and others added 28 commits March 17, 2016 20:06
@tylerhcarter
Add foundation class for Stream Notifications
3a7d0da
@tylerhcarter
Rename to Alerts
b298f40
@tylerhcarter
Add in alerts plugin tests
d1883f9
@tylerhcarter
Create alert data class
b5ff3ae
@tylerhcarter
Fix formatting
732c04d
@tylerhcarter
Introduce primitive title generator
8d7df1c 
Needs filters to expand capabilities in more scenarios
@tylerhcarter
Add meta boxes
5487f47
Move Alerts submenu item above Settings
5eee26d
Merge branch 'alerts' of https://github.com/xwp/stream into alerts
b81a31e
Enqueue select2 styles on Alerts pages
420cf55
@tylerhcarter
Activate select boxes
64892eb
@tylerhcarter
Fix post CSS
03b5a2a
@tylerhcarter
Introduce Preview_List_Table
dbce5cb
@tylerhcarter
Remove unused variable
53bc526
@tylerhcarter
Add i18n
596310c
@tylerhcarter
Beautify table
daac1d6 
Eventually should move to a common class/id that can be used on the
table of both pages.
@tylerhcarter
Only save on alerts pages
ac5be99
@tylerhcarter
Add Alert Notifiers
8ecf62e 
Added Notifier base class
Processes records as they are recorded
Added Die, Null, and Menu Alert Notifier
@tylerhcarter
Fix styling
4e36b43
@tylerhcarter
Ignore XSS
eb75c81 
Already filtered
@tylerhcarter
Add nonce
259b0ce
@tylerhcarter
Fix spaces vs tabs
0e2b374
@tylerhcarter
Fix whitespace vs tabs
b4c801d 
Add escaping
@tylerhcarter
Remove Notifier_Die from production
2bf07f8
@tylerhcarter
Fix whitespace vs tabs
c0faaf9
@tylerhcarter
Fixed whitespace vs tabs
30a1bee
@tylerhcarter
Create form generator
7023888 
Add notification meta box
@tylerhcarter
Merge branch 'develop' into alerts
7263770
@tylerhcarter tylerhcarter self-assigned this Apr 19, 2016
@tylerhcarter tylerhcarter added this to the 3.1 milestone Apr 19, 2016
jacobschweitzer and others added 28 commits September 27, 2016 11:30
@jacobschweitzer
Change IFTT to IFTTT.
9de3ae6
@jacobschweitzer
Fix alerts trash page links including duplication issue and delete no…
5ba7640 
…t working.
@jacobschweitzer
Add new alert left column alignment, moving CSS from admin to alerts-…
4326f50 
…list, and CSS cleanup.
Update alerts quick edit styles
7909b3b
Remove colon from Status label in Alerts quick edit
33f430a
Remove colon from Alert me When label in Alerts quick edit
d22e430
Relayout Quick edit alerts settings
14b9a80
@jacobschweitzer
Make alert type settings JS more generic and remove references to spe…
843c54c 
…cific alert type settings.
@jacobschweitzer
Remove display_new_fields methods. Refactoring display_fields methods…
82a22a4 
…. Refactoring load_alerts_settings JS function.
@jacobschweitzer
Add new alert submit button text changed from Update to Save.
4a15a21
@jacobschweitzer
Highlight color is now a record meta not an alert meta and ifttt does…
3cf730d 
… not add Stream meta.
@jacobschweitzer
Updated tests and changed get_title function.
f92a4d8
Add external links to IFTTT in Alert Type
f9c7f51
@jacobschweitzer
Set title for new alerts.
bb82ff8
@jacobschweitzer
Merge branch 'alerts' of github.com:xwp/stream into alerts
5884b38
@jacobschweitzer
Fix style not being applied to select2 dropdowns and other elements.
6fbaa86
@jacobschweitzer
Fix issue with alert status not being updated without refresh. Remove…
0b8aae7 
… un-needed code for actions related to select2.
@jacobschweitzer
Change edit alert link on main Stream page and remove View link.
b66e0ee
@jacobschweitzer
Scroll to and open edit alert box when hash is in URL.
a52a32d
@jacobschweitzer
Add edit alert link to email alerts.
9dca216
@jacobschweitzer
Improve alerts scrolling animation when hash is in URL.
d59fc14
@jacobschweitzer
Add description before alert type options and fix blank info in email…
4b3942d 
… alert.
@jacobschweitzer
PHPCS fixes - space around concat operator.
348afd6
Better email alert message
6224ff6
Use admin_url instead of wp-admin string
a901591
Update alert descriptions
7bc4ea0
Add link to a video tutorial for IFTTT
841e783
Escape tutorial link output
3bd9b19
@lukecarbis lukecarbis merged commit e42d8f8 into develop Oct 31, 2016
@lukecarbis lukecarbis deleted the alerts branch October 31, 2016 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
5 participants
@tylerhcarter @lukecarbis @johnregan3 @jwold @jacobschweitzer