Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network Admin Bugfixes #899

Merged
merged 5 commits into from
Dec 6, 2016
Merged

Network Admin Bugfixes #899

merged 5 commits into from
Dec 6, 2016

Conversation

lukecarbis
Copy link
Contributor

@lukecarbis lukecarbis commented Dec 6, 2016 •
edited
Loading

Resolves #867 .
Resolves #886 .

@lukecarbis
Copy link
Contributor Author

@johnregan3 Would you mind code reviewing this PR? Only a couple of lines have changed.

johnregan3
johnregan3 approved these changes Dec 6, 2016
View reviewed changes
Copy link
Contributor

@johnregan3 johnregan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukecarbis Looks good, buddy!

@lukecarbis lukecarbis merged commit 06fa9a5 into develop Dec 6, 2016
@lukecarbis lukecarbis deleted the bugfix/network-admin branch December 6, 2016 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnregan3 johnregan3 johnregan3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukecarbis @johnregan3