Add post slug field #148
Add post slug field #148
Conversation
The slug post type support is an invention
|
@westonruter We need to filter the post link so it uses the preview URL if the slug is dirty or we get a 404. I'm looking into it now. |
|
@valendesigns Is this #42? I was thinking the changing of the slug was going to be a problem, but the full page refreshes continued to work even when the slug was being changed. I wasn't able to see a 404. |
|
@westonruter I can make it work without #42. |
|
@westonruter So it's not pretty but it does the job. |
|
@valendesigns what were the steps that you used to reproduce the 404? |
|
|
@valendesigns wouldn't it be better to just use preview links across the board? See 97ddef1. |
|
That sounds like a brilliant idea, I love it!
|
| if ( $post_status_match || $post_slug_mismatch ) { | ||
| $permalink = Edit_Post_Preview::get_preview_post_link( $post ); | ||
| } | ||
| if ( is_customize_preview() ) { |
There was a problem hiding this comment.
We want this on the front-end for Snapshots, as well.
There was a problem hiding this comment.
@valendesigns Humm. Why should it be on the snapshotted frontend as well?
And if so, what would be the best way to detect if it is a frontend snapshot preview?
There was a problem hiding this comment.
@westonruter We can worry about it later, it's not critical since we haven't setup a way to navigate in the snapshot on the front-end. We'll tackle that later. For now we can just merge and move forward. Thoughts?
Placeholder field updates live as title changes.
Fixes #63