This repository has been archived by the owner on Dec 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 37
Add control to manipulate the post parent #233
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65.
Continuation of #189.
get_pages()
support in Ensure that previewed changes apply on get_pages filter #241 via Add support for including previewed changes in calls to get_pages() #250.\WP_Customize_Posts::get_post_parent_choices()
is only returningpage
posts. We would need to get all posts of all post types for this to work. At the very least this data needs to be loaded via Ajax, but likely what should be done is:wp_dropdown_pages()
provides, a deficiency with\WP_Customize_Posts::get_post_parent_choices()
.wp_dropdown_pages
support to the selector control.page_attributes_dropdown_pages_args
filter (this really only makes sense if using object_selector). This could also be implemented later, just as implementing the page-specific templates (theme_page_templates
filter) is not yet done.Other items postponed for another time:
page_for_posts
auto-loaded for non-hierarchical posts.) See List all posts of a given post type in the section #146.