Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the +e plugins not working #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alfred-chan
Copy link

Replace plugins with plugins_ in env. variable and then eval it as list variable in pluginrc.zsh

Use plugins_ instead of plugins and then eval it to make plugins to become real list object in shell script. But not a string.
Updated the document that it should use plugins_ instead of plugins to pass the plugins variable
@anki-code
Copy link
Member

anki-code commented Jul 9, 2020

Hello @alfred-chan and welcome!
I can repeat this issue:

$ xxh myhost +s zsh +e plugins='(git ubuntu)' +v +e ZSH_THEME='clean'                                                                                                                                                                 
...
...
Entrypoint env: raw=plugins=KGdpdCB1YnVudHUp, name=plugins, value=(git ubuntu)
Entrypoint env: raw=ZSH_THEME=Y2xlYW4=, name=ZSH_THEME, value=clean
Load plugin /home/user/.xxh/.xxh/shells/xxh-shell-zsh/build/zsh-bin/bin/../../../../../plugins/xxh-plugin-zsh-ohmyzsh/build/pluginrc.zsh
[oh-my-zsh] plugin '(git ubuntu)' not found
myhost:~/ $ echo $plugins                                                                                                                                                                                                       
(git ubuntu)
myhost:~/ $

But it looks like the problem is not in this repo. This should be fixed in the zsh shell entrypoint:

https://github.com/xxh/xxh-shell-zsh/blob/master/entrypoint.sh#L56-L66

I'm not the active zsh user so please check my logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants