Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails on FreeBSD 12.1 #94

Closed
yurivict opened this issue Apr 28, 2020 · 7 comments
Closed

Fails on FreeBSD 12.1 #94

yurivict opened this issue Apr 28, 2020 · 7 comments
Assignees
Labels
bug Something isn't working os:freebsd
Milestone

Comments

@yurivict
Copy link

Version 3.5.1

Fails without printing anything:

$ gotop
$ echo $?
2

The old project worked fine on FreeBSD.

@xxxserxxx xxxserxxx self-assigned this Apr 28, 2020
@xxxserxxx xxxserxxx added bug Something isn't working os:freebsd labels Apr 28, 2020
@xxxserxxx xxxserxxx added this to the v4.0.0 milestone Apr 28, 2020
@xxxserxxx
Copy link
Owner

Which was the previous version you used (that worked)? Does FreeBSD use XDG directories? If so, the log file will be in ~/.cache/gotop/errors.log; if not, it may be in ~/.gotop/errors.log. It would be useful for me to see that.

@yurivict
Copy link
Author

Which was the previous version you used (that worked)?

gotop-3.0.0_1 (from the cjbassi account)

Does FreeBSD use XDG directories? If so, the log file will be in ~/.cache/gotop/errors.log

$ cat /home/yuri/.local/state/gotop/errors.log.1
panic: assignment to entry in nil map

goroutine 1 [running]:
github.com/xxxserxxx/gotop/v3/devices.update(0xc0001c2ae0, 0x4037ee02c0000000)
	/usr/ports/sysutils/gotop/work/gotop-3.5.1/devices/temp_freebsd.go:28 +0x19a
github.com/xxxserxxx/gotop/v3/devices.UpdateTemps(0xc0001c2ae0)
	/usr/ports/sysutils/gotop/work/gotop-3.5.1/devices/temp.go:15 +0x84
github.com/xxxserxxx/gotop/v3/widgets.(*TempWidget).update(0xc0001d40c0)
	/usr/ports/sysutils/gotop/work/gotop-3.5.1/widgets/temp.go:118 +0x44
github.com/xxxserxxx/gotop/v3/widgets.NewTempWidget(0xc000000043, 0x8ffb17)
	/usr/ports/sysutils/gotop/work/gotop-3.5.1/widgets/temp.go:49 +0x162
github.com/xxxserxxx/gotop/v3/layout.makeWidget(0xc000024ce0, 0x18, 0xc000024ca0, 0x1d, 0x511ece, 0xa, 0x7, 0x0, 0x0, 0x0, ...)
	/usr/ports/sysutils/gotop/work/gotop-3.5.1/layout/layout.go:182 +0x9b8
github.com/xxxserxxx/gotop/v3/layout.processRow(0xc000024ce0, 0x18, 0xc000024ca0, 0x1d, 0x511ece, 0xa, 0x7, 0x0, 0x0, 0x0, ...)
	/usr/ports/sysutils/gotop/work/gotop-3.5.1/layout/layout.go:117 +0x41b
github.com/xxxserxxx/gotop/v3/layout.Layout(0xc00007be00, 0x4, 0x4, 0xc000024ce0, 0x18, 0xc000024ca0, 0x1d, 0x511ece, 0xa, 0x7, ...)
	/usr/ports/sysutils/gotop/work/gotop-3.5.1/layout/layout.go:41 +0x189
main.main()
	/usr/ports/sysutils/gotop/work/gotop-3.5.1/cmd/gotop/main.go:414 +0x6d4

@xxxserxxx
Copy link
Owner

Thank you.

@xxxserxxx xxxserxxx modified the milestones: v4.0.0, 3.5.2 Apr 28, 2020
xxxserxxx added a commit that referenced this issue Apr 28, 2020
@xxxserxxx
Copy link
Owner

I really need to find a FreeBSD VM to test this stuff on :-/

As soon as it's done buiding, I'll push out the release.

Thanks for the report.

@xxxserxxx
Copy link
Owner

@yurivict : Release v3.5.2 addresses this bug.

@yurivict
Copy link
Author

yurivict commented Apr 28, 2020

It runs now:
image

@xxxserxxx
Copy link
Owner

Thanks for the confirmation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working os:freebsd
Projects
None yet
Development

No branches or pull requests

2 participants