Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homework 1 #10

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Homework 1 #10

wants to merge 3 commits into from

Conversation

loreliawand
Copy link

Исправлены замечания, которые были на ревью

Copy link
Owner

@xzfantom xzfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пара замечаний, а так вроде хорошо

src/App.js Outdated

mySubmit = (event) => {
event.preventDefault();
let result = {};
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Для копирования объекта проще использовать spread: let result = {...this.state}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Исправлено

src/App.js Outdated
import FormHeader from './components/FormHeader';
import InputField from './components/InputField';
import TextAreaField from './components/TextAreaField';
import './App.css';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

По условию были указаны css модули

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Добавлены модули и удалён общий файл css

Copy link
Owner

@xzfantom xzfantom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

как по мне, так хорошо) @poulkud

};
}

genHandler = (fieldName) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

странное название

Copy link
Collaborator

@poulkud poulkud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

исправить комменты. Апрув

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants