-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homework 1 #10
base: main
Are you sure you want to change the base?
Homework 1 #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Пара замечаний, а так вроде хорошо
src/App.js
Outdated
|
||
mySubmit = (event) => { | ||
event.preventDefault(); | ||
let result = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Для копирования объекта проще использовать spread: let result = {...this.state}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Исправлено
src/App.js
Outdated
import FormHeader from './components/FormHeader'; | ||
import InputField from './components/InputField'; | ||
import TextAreaField from './components/TextAreaField'; | ||
import './App.css'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
По условию были указаны css модули
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Добавлены модули и удалён общий файл css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
как по мне, так хорошо) @poulkud
}; | ||
} | ||
|
||
genHandler = (fieldName) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
странное название
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
исправить комменты. Апрув
Исправлены замечания, которые были на ревью