-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Websockets Drawing Example #76
Conversation
Don't you want to use https://github.com/y-crdt/ypy-websocket for that? |
@davidbrochart that was my original idea, but I ran into an error that I couldn't debug. We could figure out the issue and replace the websocket logic. The error involved a buffer read that expected 2 bytes and received 0. |
Difficult to see where it could come from, but if you still have the code it would be interesting to open an issue with it. |
Sounds good, I'll create a minimal example and post an issue to the |
if update != b'\x00\x00': | ||
self.send_q.put_nowait(update) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Horusiath I noticed that the observe_after_transaction
is running in a tight loop with an empty update message when nothing has changed. Is this happening due read-only transaction operations in the draw()
loop that don't change the state?
Co-authored-by: Kevin Jahns <kevin.jahns@protonmail.com>
Added simple collaborative drawing example to a new
examples
folder.