Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add empty function bodies #125

Merged
merged 4 commits into from
Nov 13, 2022
Merged

Add empty function bodies #125

merged 4 commits into from
Nov 13, 2022

Conversation

adamhutchings
Copy link
Collaborator

I cannot test the generation properly until after #123 is merged. But the rest of it works fine.

JakeRoggenbuck
JakeRoggenbuck approved these changes Nov 13, 2022
View reviewed changes
Copy link
Member

@JakeRoggenbuck JakeRoggenbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@adamhutchings
Copy link
Collaborator Author

I removed the checks manually and confirmed that it worked.

thondascully
thondascully approved these changes Nov 13, 2022
View reviewed changes
Copy link
Collaborator

@thondascully thondascully left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peer reviewed 👍

note: If you end up adding more function types for some reason, a switch case is better served than if statements

@adamhutchings adamhutchings merged commit 17f2814 into y-flat:main Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeRoggenbuck JakeRoggenbuck JakeRoggenbuck approved these changes

@thondascully thondascully thondascully approved these changes

@dekrain dekrain Awaiting requested review from dekrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamhutchings @JakeRoggenbuck @thondascully