Use current user's IDs when reading/writing files within mounted directories in containers #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirkrodrigues
requested changes
Oct 9, 2021
wraymo
force-pushed
the
rootless_container
branch
2 times, most recently
from
d4cf07b to
c4ac139
Compare
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| from clp_py_utils.clp_config import CLPConfig | |||
|
|
|||
| ROOT_DIR = '/opt' | |||
There was a problem hiding this comment.
Can we change this to CONTAINER_CLP_INSTALL_PREFIX?
wraymo
force-pushed
the
rootless_container
branch
from
c4ac139 to
23ced86
Compare
|
Some explicitly user flag specified in docker container exec commands inside scripts found under the sbin directory is redundant. Can we remove them? |
wraymo
force-pushed
the
rootless_container
branch
from
23ced86 to
ceb2ea8
Compare
jackluo923
changed the title
thepegasos
added a commit
to thepegasos/clp
that referenced
this pull request
Nov 29, 2022
- I think the line y-scope#10 got carried away from the clp-py-utils. - For these packages to work, we need to copy these local directories to site-packages. Not clp-py-utils again and again. - Thus, the proposed correction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.