Aligns variable placeholder and float encoding with IR format specification #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haiqi96
commented
Apr 25, 2023
| @@ -131,12 +134,12 @@ QueryToken::QueryToken (const string& query_string, const size_t begin_pos, cons | |||
|
|
|||
| if (!converts_to_non_dict_var) { | |||
| // Dictionary variable | |||
| m_type = Type::DictOrIntVar; | |||
| m_type = Type::DictionaryVar; | |||
There was a problem hiding this comment.
This seems to be incorrect even at the first place? what if a wildcard is at the middle?
example: log = "INFO static text 12345" and the query string is "12*45"
haiqi96
commented
Apr 25, 2023
haiqi96
changed the title
kirkrodrigues
requested changes
May 2, 2023
components/core/src/utils/make_dictionaries_readable/make-dictionaries-readable.cpp
Outdated
Show resolved
Hide resolved
kirkrodrigues
requested changes
May 3, 2023
kirkrodrigues
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
Use IR format for CLP message encoding and floating number
Validation performed
Compression ratio delta:
hadoop-24hrs. +0.5%
hadoop-30gb. < -0.01%
openstacks-24hr. -0.2%
spark. -0.3%
var-logs. -2%