Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for compressing CLP IR streams. #152

Merged
merged 128 commits into from
Aug 29, 2023
Merged

Add support for compressing CLP IR streams. #152

merged 128 commits into from
Aug 29, 2023

Conversation

haiqi96
Copy link
Contributor

@haiqi96 haiqi96 commented Aug 15, 2023

References

Description

Validation performed

haiqi96 added 30 commits May 29, 2023 18:23
@haiqi96
Backup
02d2b48
@haiqi96
simple working version backup
21581c0
@haiqi96
backup
5ff962e
@haiqi96
Allow seeking beyond end of file
791cfee
@haiqi96
Use BufferReader for Decoder
d542e47
@haiqi96
small clean up
3cb8f7c
@haiqi96
Fixes but yet to verify
21a37a0
@haiqi96
small clean up
827c762
@haiqi96
Some refactoring and decompression looks ok
1971ae4
@haiqi96
ok for compression
1764cfb
@haiqi96
bug fix for proper compression
5319067
@haiqi96
make error code interface matches with what's expected
f616add
@haiqi96
Support checkpoint in new file reader
8d2fce0
@haiqi96
Make existing clp code use checkpoint feature
d2fc530
@haiqi96
updated some comments on potential improvements and add a temporary u…
921517a 
…nit test to help refactoring
@haiqi96
remove eof flag
38b0da7
@haiqi96
remove checkpoint related functions from readerbuffer
e663312
@haiqi96
refactor try_read logic
fd02a5f
@haiqi96
clean up
237bb3f
@haiqi96
Allow more flexible reset and delay buffer loading for seek
6cd7516
@haiqi96
refactor
eacad4a
@haiqi96
rename new file reader to something else
dc0d91e
@haiqi96
More refactoring
ccad421
@haiqi96
remove fstat dependency from libarchive reader
2324a21
@haiqi96
Remove code specific for BFR
9e48e12
@haiqi96
Remove BFR dependency on BR
57dd310
@haiqi96
remove m_cursor and replace with buffer begin_pos
d84276c
@haiqi96
Add UTF8 utility to the FBR.
5845805
@haiqi96
replace UTF8 validation logic
b90e0d6
@haiqi96
Some personal preference
e9230d0
haiqi96
haiqi96 commented Aug 16, 2023
View reviewed changes
components/core/src/IrMessageParser.cpp Outdated Show resolved Hide resolved
components/core/src/IrMessageParser.hpp Outdated Show resolved Hide resolved
components/core/src/ParsedIrMessage.cpp Outdated Show resolved Hide resolved
haiqi96 and others added 8 commits August 16, 2023 12:12
@haiqi96
small fixes
788bf36
@kirkrodrigues
Refactoring/restructuring:
0629ea0 
- Replace IrMessageParser with LogEventDeserializer and ParsedIrMessage with LogEvent
- Rewrite classes using RAII and avoid exceptions to make embedded development smoother
- Pass IR log event through to writer::Archive to stay consistent with the raw log event encoding path
- Deduplicate code
@kirkrodrigues
Address todos: Rename generic_parse_tokens -> deserialize_ir_message …
f8f587a 
…and deduplicate update_segment_indices.
@kirkrodrigues
Add boost-outcome as submodule; LogEventDeserializer: Explicitly spec…
48d7b01 
…ify error returns.
@kirkrodrigues
Clean-up LogEventDeserializer; Move template methods into cpp with ex…
1170333 
…plicit specializations.
@kirkrodrigues
FileCompressor: Move template implementation into cpp with explicit s…
7ae1e86 
…pecialization.
@kirkrodrigues
Archive: Move template implementation into cpp with explicit speciali…
9e3e6b4 
…zation.
@kirkrodrigues
Remove unnecessary cAlwaysFalse const.
8cbefa4
haiqi96
haiqi96 commented Aug 29, 2023
View reviewed changes
Copy link
Contributor Author

@haiqi96 haiqi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kirkrodrigues kirkrodrigues merged commit 03cedcd into y-scope:main Aug 29, 2023
@kirkrodrigues kirkrodrigues mentioned this pull request Aug 30, 2023
Merged
@haiqi96 haiqi96 deleted the ir-decompression-new branch January 25, 2024 21:27
@kirkrodrigues kirkrodrigues changed the title Ir decompression new Add support for compressing CLP IR streams. May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidlion davidlion davidlion approved these changes

@kirkrodrigues kirkrodrigues kirkrodrigues approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@haiqi96 @kirkrodrigues @davidlion