clp-package: Fix bugs introduced in #460:

[haiqi96]

Description

This PR fixes two bugs in query worker scripts, introduced by #460

1. Fixes a bug where the search results are written to task_id collection. They should be written to job_id collection
2. Fixes a bug where an int is converted to string before joined as part of the command

Validation performed

Tested with log viewer.

[junhaoliao]

Lgtm. How about changing the PR title to "clp-package: Fix type conversions in query worker scripts."?

[haiqi96]

Lgtm. How about changing the PR title to "clp-package: Fix type conversions in query worker scripts."?

hmm, it's not only type conversion. the change also updated the result collection to use job_id instead of task_id.

[junhaoliao]

Lgtm. How about changing the PR title to "clp-package: Fix type conversions in query worker scripts."?

hmm, it's not only type conversion. the change also updated the result collection to use job_id instead of task_id.

Right, sorry for the oversight. How about: clp-package: Fix issues with command generation and search results write destination in query worker scripts.

[haiqi96]

Quote reply
Reference in new issue
Edit
Hide
Delete

Lgtm. How about changing the PR title to "clp-package: Fix type conversions in query worker scripts."?

hmm, it's not only type conversion. the change also updated the result collection to use job_id instead of task_id.

Right, sorry for the oversight. How about: clp-package: Fix issues with command generation and search results write destination in query worker scripts.

@kirkrodrigues any suggestions?

[kirkrodrigues]

How about:

clp-package: Fix bugs introduced in #460:

• Write search results to collection named job_id rather than task_id.
• Convert int to str in IR extraction command generation.

Ordinarily, I'd make these two separate PRs so the commit message is easier to write, but above is how I'd write it so that it makes sense why we're fixing both bugs in one PR.