Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve input paths for compression before passing them to the container #49

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

kirkrodrigues
Copy link
Member

... and minor logging fixes.

References

#29

Description

The container cannot compress relative paths since it does not know the root of the path. So instead, we:

  • Resolve input paths passed to sbin/compress before passing them to the container.
  • Raise an error if the user specifies relative paths in a list of paths for compression (sbin/compress --input-list).

Validation performed

  • Compressed a relative path
  • Tried to compress a list of relative paths and validated that an error was raised
  • Compress a list of absolute paths

@kirkrodrigues kirkrodrigues merged commit 12b123e into main Feb 12, 2022
@kirkrodrigues kirkrodrigues deleted the fix-29 branch February 12, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants