webui: Improve UI of links for viewing search results in context. #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Henry8192 Please help triage this review. Thanks! |
| {" "} | ||
| <a | ||
| className={"search-results-file-link"} | ||
| rel={"noopener noreferrer"} |
There was a problem hiding this comment.
What's the reasoning behind setting these? Fwiw, _blank seems to imply noopener now:
Note: Setting target="_blank" on elements implicitly provides the same rel behavior as setting rel="noopener" which does not set window.opener.
There was a problem hiding this comment.
Ah.. I didn't read the docs when I wrote this.
Apparently the behaviour change is fairly recent (with Chrome adapting it only since 2021) so we might better keep the noopener:
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/a#browser_compatibility:~:text=target%3D%22_blank%22%20implies%20rel%3D%22noopener%22%20behavior
kirkrodrigues
approved these changes
Aug 19, 2024
junhaoliao
changed the title
jackluo923
pushed a commit
to jackluo923/clp
that referenced
this pull request
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Validation performed
Sample screenshot:
