-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-actions: Remove pre-installed Go binaries that conflict with brew's installs on macOS (fixes #551). #552
Conversation
WalkthroughThe pull request modifies the GitHub Actions workflow file Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/workflows/clp-core-build-macos.yaml (1)
52-52
: Approved: Good solution to resolve Go installation conflicts.The added command
rm -f /usr/local/bin/go*
effectively addresses the issue of pre-installed Go binaries interfering with Homebrew installation. This change aligns well with the PR objectives and should resolve thebrew link
failure described in the linked issue.For improved clarity and maintainability, consider adding a comment explaining the purpose of this specific removal:
# Remove pre-installed Go binaries to avoid conflicts with Homebrew installation rm -f /usr/local/bin/go*This addition will help future maintainers understand the rationale behind removing Go binaries.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the PR title, how about:
gh-actions: Remove pre-installed Go binaries that conflict with brew's installs on macOS (fixes #551).
…s installs on macOS (fixes y-scope#551). (y-scope#552)
…s installs on macOS (fixes y-scope#551). (y-scope#552)
Description
This PR fixes #551 by removing pre-installed Go binaries. The pre-installed Go binaries prevent
brew
from installing Go properly. This PR fixes the issue by removing the pre-installed binaries before runningbrew
.Validation performed
Ensure all workflows passed.
Summary by CodeRabbit