Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add GH workflow to validate PR titles follow Conventional Commits. #587

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

LinZhihao-723
Copy link
Member

@LinZhihao-723 LinZhihao-723 commented Nov 12, 2024

Description

Convention Commits is a specification for writing commit messages (or in our case, PR titles) that makes it easy to see at a glance what change the commit makes which in turn makes it easier to generate release notes.

This PR adds a workflow to check PR titles match the spec.

Validation performed

Summary by CodeRabbit

  • New Features

    • Updated the pull request template to include guidelines for following the Conventional Commits specification for titles.
    • Introduced a new GitHub Actions workflow to enforce title formatting on pull requests.
  • Documentation

    • Improved instructions in the pull request template for setting meaningful titles.
  • Chores

    • Added a new workflow file to manage pull request title checks.

Copy link
Contributor

coderabbitai bot commented Nov 12, 2024

Warning

Rate limit exceeded

@LinZhihao-723 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 27 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 62c3bf8 and 9ec40e2.

Walkthrough

This pull request introduces modifications to the pull request template and adds a new GitHub Actions workflow. The .github/PULL_REQUEST_TEMPLATE.md file now specifies that pull request titles should adhere to the Conventional Commits specification, providing an example format. Additionally, a new workflow file, .github/workflows/clp-pr-title-checks.yaml, is created to enforce this title format on pull request events targeting the main branch, utilizing a specific GitHub action for validation.

Changes

File Change Summary
.github/PULL_REQUEST_TEMPLATE.md Updated instructions for PR title to follow Conventional Commits specification, with examples.
.github/workflows/clp-pr-title-checks.yaml Introduced a new workflow for checking PR titles against the Conventional Commits format.

Possibly related PRs

Suggested reviewers

  • anlowee

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (3)
.github/PULL_REQUEST_TEMPLATE.md (3)

2-4: Enhance clarity of the Conventional Commits requirement

The instructions should be more specific about the required format. Consider adding the basic structure of a conventional commit.

 Set the PR title to a meaningful commit message that:
 - follows the Conventional Commits specification (https://www.conventionalcommits.org).
 - is in imperative form.
+- uses the format: <type>[optional scope]: <description>
+  where type is one of: feat, fix, docs, style, refactor, perf, test, chore, ci, build

5-6: Add more diverse examples of conventional commits

While the current example is good, providing multiple examples would better illustrate the variety of commit types.

 Example:
 fix: Don't add implicit wildcards ('*') at the beginning and the end of a query (fixes #390).
+Additional examples:
+feat(parser): Add support for parsing multi-line logs
+docs: Update installation instructions for Windows users
+perf: Optimize memory usage in log processing

Line range hint 1-14: Consider adding validation section for PR titles

Since this template is being updated alongside a new GitHub workflow for PR title validation, it would be helpful to mention the automated checks.

+Note: Your PR title will be automatically checked to ensure it follows the Conventional Commits format.
+If the check fails, please revise your PR title according to the format above.
+
 # Description
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between f3b1cf6 and 110eb79.

📒 Files selected for processing (2)
  • .github/PULL_REQUEST_TEMPLATE.md (1 hunks)
  • .github/workflows/clp-pr-title-checks.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • .github/workflows/clp-pr-title-checks.yaml

Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
@LinZhihao-723
Copy link
Member Author

Tested after moving permission to job level and it should be good: https://github.com/LinZhihao-723/clp/actions/runs/11807413560

@LinZhihao-723 LinZhihao-723 merged commit 2dfcd8a into y-scope:main Nov 12, 2024
5 checks passed
jackluo923 pushed a commit to jackluo923/clp that referenced this pull request Dec 4, 2024
y-scope#587)

Co-authored-by: kirkrodrigues <2454684+kirkrodrigues@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants