-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Taskfile contribution guidelines to use utility tasks in yscope-dev-utils. #19
base: main
Are you sure you want to change the base?
Conversation
After carefully reading the previous version of doc, I finally understands why we need the generates for the checksum. So yeah, I didn;t read the doc carefully and wasn't awared that validate-checksum will delete the checksum file if validation has failed. Basically, I mis-interpreted Since now we are removing the implementation details of I think it might be better to either
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
On hold until we decide how to address the review concerns. |
Description
y-scope/yscope-dev-utils#2 added taskfiles containing the checksuming utility tasks listed in the Taskfile contribution guidelines. Thus, we can now remove them from the contribution guidelines and update the example to use the utility tasks in yscope-dev-utils directly.