Conditional independency tests #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yet to run tox, finish the test cases
…0-causal-inference/eliater into conditional_independency_tests
Adding method for choosing default test. Adding tests for get_state_space_map and choose_default_test
cthoyt
reviewed
Sep 22, 2023
cthoyt
reviewed
Sep 25, 2023
cthoyt
reviewed
Sep 25, 2023
cthoyt
reviewed
Sep 25, 2023
cthoyt
reviewed
Sep 25, 2023
…0-causal-inference/eliater into conditional_independency_tests
Split unrelated tests, remove src. perfix in imports, improvise the logic for choose_default_test
cthoyt
added a commit
that referenced
this pull request
Dec 4, 2023
This PR adds the `eliater.workflow` function, which combines the following: 1. Add undirected edges between d-separated nodes for which a data-driven conditional independency test fails (waiting on #1, but there is a comment for later) 2. Remove nuissance variables. 3. Estimates the average causal effect (ACE) of the treatments on outcomes
cthoyt
reviewed
Dec 4, 2023
src/eliater/network_validation.py
Outdated
| :alt: alternate text | ||
| :align: right | ||
|
|
||
| The results show that out of 35 cases, 1 failed. The failed test is |
There was a problem hiding this comment.
This needs to be reinvestigated and rewritten with new results
cthoyt
added a commit
that referenced
this pull request
Dec 14, 2023
This PR squashes all of the example updates before #1 gets merged --------- Co-authored-by: Pruthvi Navada <pnavada.pruthvi@gmail.com> Co-authored-by: Sara Taheri <srtaheri66@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4