-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to disable collection of general metrics (of the whole Sidekiq setup) #20
Allow to disable collection of general metrics (of the whole Sidekiq setup) #20
Conversation
a2eb2c7
to
3cba342
Compare
Signed-off-by: Valentin Kiselev <mrexox@evilmartians.com>
3cba342
to
25c1ce0
Compare
Hey! Thanks for the pull request! I like the idea as it can be really useful on large Sidekiq installation. I just pushed few changes: using anyway_config for configuration (it allows to use not only environment variables, but many other sources) and renaming of setting (however, I'm still not sure about correct naming). Let's discuss! |
I like the name |
Signed-off-by: Valentin Kiselev <mrexox@evilmartians.com>
Signed-off-by: Valentin Kiselev <mrexox@evilmartians.com>
…rics in worker processes
After further thinking I thought that it is enough to use single setting as force switch for general/global/aggregate metrics (it is by default on in Sidekiq processes and off in non-Sidekiq, thanks for the idea!). |
If you run Kubernetes and have several pods running sidekiq, these general metrics can be overkill. So it is better to choose one pod that will publish these metrics instead of all pods publishing the same values.
To make it simple, I offer the solution with ENV variable checking. But I am open to discussion about how to make it more accurate.
UPD: Also added the setting to force collecting metrics even if an application is not a Sidekiq runner.