Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slow CSS selector #1115

Merged
merged 2 commits into from
Jun 6, 2016
Merged

Fix slow CSS selector #1115

merged 2 commits into from
Jun 6, 2016

Conversation

nmielnik
Copy link
Member

@nmielnik nmielnik commented Jun 6, 2016

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
New tests added? updated
License MIT

Description

Fixed a slow CSS selector that our linter was complaining about:

Linting dist/css/medium-editor.css...ERROR
[L209:C1]
WARNING: Unqualified attribute selectors are known to be slow. Unqualified attribute selectors are known to be slow. (unqualified-attributes) Browsers: All

To fix this, we can add a medium-editor-element class to the editor element, and update the CSS selector to use that instead of an unqualified attribute selector.

@j0k3r
Copy link
Contributor

j0k3r commented Jun 6, 2016

I'm ok with that 👍

@j0k3r j0k3r merged commit a8d2932 into master Jun 6, 2016
@j0k3r j0k3r deleted the css-lint-fix branch June 6, 2016 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants