Fix Jasmine Unit Test errors #1385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had to fix also the Travis build. Not sure why, but you were still using NodeJS 0.10, while it's very safe to use the latest LTS. I hope it's fine for you. |
|
Changes Unknown when pulling 18c64e7 on julianxhokaxhiu:bugfix/test-cases into ** on yabwe:master**. |
j0k3r
approved these changes
Nov 8, 2017
Therefore make the container a bit bigger and make the test run properly. If not, the 'left' property is set to auto and the test case fails.
Fix undefined is not a constructor (evaluating 'range.startContainer.getBoundingClientRect()')
It was too small for the toolbar to fit
|
@j0k3r Fixed conflicts, you can merge it now if you want. |
|
Changes Unknown when pulling 55dec60 on julianxhokaxhiu:bugfix/test-cases into ** on yabwe:master**. |
|
You remove the change of nodejs version? |
|
Yeah, I kept your choice in master, in order to avoid conflicts while merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bunch of unit tests that were failing upon running
npm run build. Now everything builds fine again.--
Please, don't submit
/distfiles with your PR!