Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Change request to @cypress/request #1145

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

danielperez9430
Copy link
Collaborator

@danielperez9430 danielperez9430 commented Oct 24, 2023

  • All tests pass
  • I have run npm run doc

Description

@cypress/request is a fork of request that they use Cypress. And is actually updated and also fix the problem of the vulnerability of tough-cookie dependency.

  • Change request to @cypress/request
  • Change request-promise to @cypress/request-promise

This change is not a breaking change and also can be safe for update in the current version without need to drop the support for old node versions until we do a more deep refactor of the package.

Related issues:

What is your opinion @yagop @kamikazechaser ?

@danielperez9430 danielperez9430 added the dependencies Pull requests that update a dependency file label Oct 24, 2023
@saeedhei
Copy link
Contributor

Does this module have the ability to update with Axios?

Copy link
Collaborator

@kamikazechaser kamikazechaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defintely better to use a maintained fork.

Copy link
Owner

@yagop yagop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Clean solution

@danielperez9430 danielperez9430 merged commit 12d4d25 into master Oct 25, 2023
1 check passed
@danielperez9430 danielperez9430 deleted the hotfix/change_request_module branch October 25, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Bugs and Review
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

4 participants