add partitions to multiple topics at once #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| readVersions: Map[String,Int]) { | ||
| // topicAndReplicaList is sorted by number of partitions each topic has in order not to start adding partitions if any of requests doesn't work with newNumPartitions | ||
| for ((topic, replicaList) <- topicAndReplicaList) { | ||
| addPartitions(curator, topic, newNumPartitions, replicaList, brokerList, readVersions.getOrElse(topic,-1)) |
There was a problem hiding this comment.
Probably should skip topics for which we don't have a readVersion to avoid potential issues with two concurrent add partitions to topics commands. You can return a list of topics for which no read version was found or some form of error object.
There was a problem hiding this comment.
I'll return an error in this case with a list of topics with no read version.
|
Can we add test for this? |
|
Added a test for addPartitionsToMultipleTopics under TestKafkaManager. |
| checkCondition(topicsWithoutReadVersion.isEmpty, TopicErrors.NoReadVersionFound(topicsWithoutReadVersion.mkString(", "))) | ||
|
|
||
| // topicAndReplicaList is sorted by number of partitions each topic has in order not to start adding partitions if any of requests doesn't work with newNumPartitions | ||
| for ((topic, replicaList) <- topicAndReplicaList) { |
There was a problem hiding this comment.
Since you are already doing the readVersion check, you can do something like this here:
for {
(topic, replicaList) <- topicAndReplicaList
readVersion = readVersions(topic)
} {
...
}
patelh
added a commit
that referenced
this pull request
Jul 30, 2015
add partitions to multiple topics at once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.