chore: upgrade to latest connect-busboy (#34)

yahoo · May 23, 2022 · f5936f8 · f5936f8
1 parent 4b6db05
commit f5936f8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/index.js b/index.js
@@ -110,13 +110,14 @@ exports.extend = function(app, options) {
         };
 
         if (options.upload && allowUpload) {
-            req.busboy.on('file', (name, file, filename, encoding, mimetype) => {
+            req.busboy.on('file', (name, file, info) => {
+                const { filename, encoding, mimeType } = info;
                 const fileUuid = uuid.v4();
                 const nameStripped = options.strip(name, 'name');
                 const filenameStripped = options.strip(filename || /*istanbul ignore next*/ '', 'filename');
                 const out = path.join(options.path, '/', fileUuid, '/', nameStripped, filenameStripped);
 
-                if (mimeTypeLimit && !mimeTypeLimit.some(type => { return type === mimetype; })) {
+                if (mimeTypeLimit && !mimeTypeLimit.some(type => { return type === mimeType; })) {
                     return file.resume();
                 }
 
@@ -131,7 +132,7 @@ exports.extend = function(app, options) {
                     file: out,
                     filename: filename,
                     encoding: encoding,
-                    mimetype: mimetype,
+                    mimetype: mimeType,
                     truncated: false,
                     done: false
                 };
@@ -156,7 +157,7 @@ exports.extend = function(app, options) {
         req.busboy.on('field', (name, data) => {
             convertParams(req.body, name, data);
         });
-        req.busboy.on('finish', () => {
+        req.busboy.on('close', () => {
             req.body = qs.parse(qs.stringify(req.body), { arrayLimit: options.arrayLimit });
             if (restrictMultiple) {
                 [req.body, req.files].forEach(fixDups);

diff --git a/package.json b/package.json
@@ -23,10 +23,10 @@
   },
   "homepage": "https://github.com/yahoo/express-busboy",
   "dependencies": {
-    "body": "~5.1.0",
-    "connect-busboy": "~0.0.1",
+    "body": "^5.1.0",
+    "connect-busboy": "^1.0.0",
     "mkdirp": "^1.0.4",
-    "qs": "^6.4.0",
+    "qs": "^6.10.3",
     "uuid": "^8.3.2"
   },
   "devDependencies": {