Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return json for error response #80

Merged
merged 1 commit into from
May 21, 2015
Merged

Return json for error response #80

merged 1 commit into from
May 21, 2015

Conversation

Vijar
Copy link
Contributor

@Vijar Vijar commented May 21, 2015

@lingyan

This is so we're consistent in sending the same format response from the middleware.

@yahoocla
Copy link

CLA is valid!

@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.12% when pulling deef81c on json_error into b3cf405 on master.

@lingyan
Copy link
Member

lingyan commented May 21, 2015

👍

Vijar added a commit that referenced this pull request May 21, 2015
@Vijar
Merge pull request #80 from yahoo/json_error
994ff4e 
Return json for error response
@Vijar Vijar merged commit 994ff4e into master May 21, 2015
@Vijar Vijar removed the in progress label May 21, 2015
@Vijar Vijar deleted the json_error branch May 21, 2015 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vijar @yahoocla @coveralls @lingyan