Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add X-Requested-With header; bug fix #84

Merged
merged 1 commit into from
Jun 1, 2015
Merged

add X-Requested-With header; bug fix #84

merged 1 commit into from
Jun 1, 2015

Conversation

lingyan
Copy link
Member

@lingyan lingyan commented Jun 1, 2015

@Vijar

…f retry after the bug fix to keep backward compatibility
@yahoocla
Copy link

yahoocla commented Jun 1, 2015

CLA is valid!

@@ -18,7 +18,7 @@ var _ = require('lodash'),
timeout: 3000,
retry: {
interval: 200,
max_retries: 2
max_retries: 0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turning retry off to keep backward compatible behavior of no automatic retry, which was due to a bug that is fixed in this commit.

@redonkulus
Copy link
Contributor

👍

var normalized = {};
var normalized = {
'X-Requested-With': 'XMLHttpRequest'
};
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

X-Requested-With is a common header used for identify Ajax requests: http://en.wikipedia.org/wiki/List_of_HTTP_header_fields#Common_non-standard_request_fields

@Vijar
Copy link
Contributor

Vijar commented Jun 1, 2015

:shipit:

lingyan added a commit that referenced this pull request Jun 1, 2015
add X-Requested-With header; bug fix
@lingyan lingyan merged commit 171d900 into master Jun 1, 2015
@lingyan lingyan deleted the x-requested-with branch June 1, 2015 18:50
@coveralls
Copy link

Coverage Status

Coverage increased (+2.56%) to 83.69% when pulling 3cf279c on x-requested-with into 7404fe7 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+2.56%) to 83.69% when pulling 3cf279c on x-requested-with into 7404fe7 on master.

@lingyan lingyan mentioned this pull request Jun 1, 2015
lingyan added a commit that referenced this pull request Jun 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants