Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle error 400 json responses and standard string responses #98

Merged
merged 1 commit into from
Jun 16, 2015
Merged

handle error 400 json responses and standard string responses #98

merged 1 commit into from
Jun 16, 2015

Conversation

davidhouweling
Copy link
Contributor

This should hopefully fix #90. I've tried to incorporate appropriate tests based on scenarios that I've seen before the commit created the problem, as well as scenarios I saw from an IIS server housing node where it stripped out the body content.

@yahoocla
Copy link

CLA is valid!

@Vijar Vijar added the ready label Jun 12, 2015
@Vijar
Copy link
Contributor

Vijar commented Jun 16, 2015

🚢

Vijar added a commit that referenced this pull request Jun 16, 2015
handle error 400 json responses and standard string responses
@Vijar Vijar merged commit 2f0d568 into yahoo:master Jun 16, 2015
@Vijar Vijar removed the ready label Jun 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetcher client not handling error properly
3 participants