Fix encoding/decoding inconsistency when using values that need scaping #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `makePath` uses pathToRegexp which in place uses encodeURIComponent for all values, when getRoute tries to match a URL generated by the router itself, it returns a double enconded value. I suspect this is the root cause for fluxible-router to avoid using parsed URLs and [bookeeping the origURL instead](1) I added tests to both `match` (indirectly through `getRoute`) and to `makePath`. Notice that if you comment or remove `decodeURIComponent` from the implementation, only 1 of the tests fails. This proves the undesired inconsistency. [1]: https://github.com/yahoo/fluxible/blob/2be37f6df6ef5d5ed7c31fae5ec14843f924b213/packages/fluxible-router/lib/History.js#L66-L73
|
LGTM. Potentially a breaking change but could also be considered a bug as well. Open to thoughts on this. |
|
This is more like a bug fix. but given the possibility of breaking change, we can publish this under 2.0. 👍 @irae Thanks for fixing. |
|
I updated the PR with changelog and version bump to 2.0.0 |
|
👍 |
|
👍 Thanks for the notes as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
makePathusespathToRegexpwhich in place usesencodeURIComponentfor all values, when getRoute tries to match a URL generated by the router itself, it returns a double enconded value.I suspect this is the root cause for fluxible-router to avoid using parsed URLs and bookeeping the origURL instead.
I added tests to both
match(indirectly throughgetRoute) and tomakePath. Notice that if you comment or removedecodeURIComponentfrom the implementation, only 1 of the tests fails. This proves the undesired inconsistency.I do hate JSON in URLs and I know it is a bad practice, and I do want to remove this from the application I am working on (nope, I didn't introduce in the first place). But I believe this to be beneficial to the router... who does not want to support
/emoji/😍/used/in/paths?@mridgway