Only append query if there is something to append #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly cosmetic, but it is really strange to have a question
mark if you don't have query, and adding checks on any application
using routr to not pass a query seems wasteful.
i.e. in my application I use:
`Object.assing({}, detaultQuery, myFuncQueryParam)` and sometimes I
get an empty object. It would be convenient if the router didn't add
the question mark.
r.makePath('my', {wat:'route'}, {});
Before this patch: /my/route?
After this patch: /my/route
|
Hello CLA bot? You forgot my PR |
|
CLA bot doesn't work weekends. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly cosmetic, but it is really strange to have a question
mark if you don't have query, and adding checks on any application
using routr seems wasteful.
i.e. in my application I use:
Object.assing({}, detaultQuery, myFuncQueryParam)and sometimes I get an empty object. It would be convenient if the router didn't add the question mark.Before this patch: /my/route?
After this patch: /my/route