Add support for question marks in hash fragments #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From [rfc3986](https://tools.ietf.org/html/rfc3986#section-3.5): > The characters slash ("/") and question mark ("?") are allowed to > represent data within the fragment identifier.
|
CLA is valid! |
|
Hi, is someone available to take a look at this? It addresses a fairly troublesome bug. |
|
Sorry for the late response @gigabo. Code changes look ok to me. 👍 |
|
|
||
| // Leave `pos` at the beginning of the query-string, if any. | ||
| ['#', '?'].forEach(function(delimiter){ | ||
| pos = url.indexOf(delimiter); |
There was a problem hiding this comment.
thanks @gigabo for the fix! would it be better to use pos = path.indexOf(delimiter)? Sorry for the delay in response, for some reason, I did not get notification of your PR :(
There was a problem hiding this comment.
Hi @lingyan. Nice catch. I've pushed a patch.
|
Great, @gigabo Once build passes, I will merge and release. Thanks a lot for your contribution! |
|
@gigabo New version 2.0.2 has been released and published to npm, with your fix: https://github.com/yahoo/routr/releases/tag/v2.0.2 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
URLs with no query string, but with a hash fragment containing
?have the portion of the hash fragment prior to the?erroneously included as part of the path.For example, given
/foo#bar?baz, the path should be/foo, but is instead/foo#bar.From rfc3986: