Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for URL's #123

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Add support for URL's #123

merged 1 commit into from
Jun 21, 2021

Conversation

rrdelaney
Copy link
Contributor

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

This PR adds support for the built-in URL type. This is supported everywhere Set and Map are supported so I don't think compatibility should be an issue.

As far as how the actual value is serialized: the string-ified URL value itself is not escaped because URL will do this for us e.g. (new URL("https://script>.com")).toString() ➡️ "https://script%3E.com/".

Copy link
Collaborator

@okuryu okuryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's put this in.

@okuryu okuryu merged commit 7f3ac25 into yahoo:main Jun 21, 2021
@okuryu
Copy link
Collaborator

okuryu commented Jun 21, 2021

published v6.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants