Add AMP validation features to support literal attribute value, e.g []. #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fansu
reviewed
Nov 10, 2020
| <p {{text}}="cart.p1_qty" class="qty_num">1</p> | ||
| <p {[text]}="cart.p1_qty" class="qty_num">1</p> | ||
|
|
||
| <!--sanitize, all should return text --> |
|
looks good. |
lafa
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inspecting the attributes for p, the "[text]" attribute is returned as "text", when these are distinct values. We are requesting a change or some feature that can return the literal value of the attribute. This is necessary for AMP validation.
At the moment, tagchowder is sanitizing Unicode characters by replacing with "_". For example, a tag that looks like,
'html ⚡4email' would be returned at the handler level as, 'html _4email'