Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mergeConfigFrom
should be called in theregister
method, it means once the package being registered, its config are ready to use. Then other services can access them safely without caring about the order of application services bootstrap.This is also mentioned in the official documentation:
publishes
is useful only in the console application, and in the console application all services will be booted, so it does not matter puttingpublishes
whether inregister
orboot
method. Some core services also put it inregister
to make code organized, such asMailServiceProvider::registerMarkdownRenderer
.