[8.0] Fix exception/warning for PHP 7.2. #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PHP Warning: count(): Parameter must be an array or an object that implements Countable in yajra/laravel-datatables-oracle/src/CollectionDataTable.php on line 69
yajra
requested changes
Oct 24, 2017
src/CollectionDataTable.php
Outdated
| @@ -65,7 +65,7 @@ public function count() | |||
| */ | |||
| public function columnSearch() | |||
| { | |||
| $columns = $this->request->get('columns'); | |||
| $columns = $this->request->get('columns') ?: []; | |||
There was a problem hiding this comment.
Maybe it is better to use the default value arg of get? Thanks!
$this->request->get('columns', []);
yajra
changed the title
yajra
changed the title
yajra
approved these changes
Oct 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you use:
Datatables::of(User::all())->toJson()In PHP 7.2 you will get:
PHP Warning: count(): Parameter must be an array or an object that implements Countable in yajra/laravel-datatables-oracle/src/CollectionDataTable.php on line 69This creates an empty array if get request it's not defined so count() doesn't fail.