Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0] Add styleci cs config. #1484

Merged
merged 1 commit into from
Oct 28, 2017
Merged

[8.0] Add styleci cs config. #1484

merged 1 commit into from
Oct 28, 2017

Conversation

yajra
Copy link
Owner

@yajra yajra commented Oct 28, 2017

Add styleci checker with Laravel presets.

@yajra yajra merged commit 80dbc5a into 8.0 Oct 28, 2017
@yajra yajra deleted the styleci branch October 28, 2017 03:18
@ElfSundae
Copy link
Contributor

👍

Personally, I prefer using the laravel preset without any custom rules, this may be more general for a Laravel package.

preset: laravel

linting: true

An alternative .php_cs config: https://github.com/ElfSundae/laravel-skeleton/blob/master/.php_cs.dist

Just FYI, you decide.

@yajra
Copy link
Owner Author

yajra commented Oct 28, 2017

What does linting do?

Anyways, I just found myself loving the aligned equals and arrays with a space on unary operators and concat. I find it more readable. :)

@ElfSundae
Copy link
Contributor

Oh, I just found linting had been deprecated https://styleci.readme.io/docs/change-log#section-27082016-linting-changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yajra @ElfSundae