Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0] Fix datatables() helper #1487

Merged
merged 2 commits into from
Nov 2, 2017
Merged

[8.0] Fix datatables() helper #1487

merged 2 commits into from
Nov 2, 2017

Conversation

ElfSundae
Copy link
Contributor

As discussed in #1462 (comment)

  • Use container binding to resolve DataTables factory
  • Support variable length parameters

@ElfSundae
Copy link
Contributor Author

ElfSundae commented Oct 28, 2017

Updated: don't support variable length parameters.

Variable length parameters for DataTable is a bad idea, and this will make our factory much complex to not work. Think about FooDataTable($query, $array), how to do autoselect for this engine, by type of $query or by type of $array or both of them?

Maybe someone wants to implement a complex DataTable, then just use new FooDataTable(...) or DataTables::foo(...) or datatables()->foo(...).

@yajra yajra merged commit 40269f0 into yajra:8.0 Nov 2, 2017
@ElfSundae ElfSundae deleted the fix-helper branch November 2, 2017 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants