New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.0] Remove useless else statements. #1553

Merged

yajra merged 1 commit into yajra:8.0 from carusogabriel:clean-elses

Dec 16, 2017

Contributor

carusogabriel commented Dec 16, 2017 •

edited

Loading

I've removed the elses when we have already returned something 🚮

We can also enable no_useless_else in StyleCI. Should we?


          Clean elses

d1d5f59

Owner

yajra commented Dec 16, 2017

@carusogabriel this looks good. Not familiar with no_useless_else settings of StlyeCI but if it does automate this step, then I'm in favor of it.

yajra changed the title ~~Clean elses~~ [8.0] Remove useless else statements.

yajra merged commit 5325027 into yajra:8.0

carusogabriel deleted the clean-elses branch

December 16, 2017 09:27

carusogabriel mentioned this pull request

[8.0] Enable no_useless_else #1554

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet