Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ambiguous column 'deleted_at' #1693

Closed
wants to merge 1 commit into from
Closed

Fix ambiguous column 'deleted_at' #1693

wants to merge 1 commit into from

Conversation

cuatao
Copy link

@cuatao cuatao commented Apr 5, 2018

Fix error ambiguous when two tables are using SoftDeletes.

@cuatao
Fix ambiguous column 'deleted_at'
bdafeee 
Fix error ambiguous when two tables are using SoftDeletes
@cuatao cuatao closed this Apr 5, 2018
@vaanholtje
Copy link

When can we expect this fix to be released?

@yajra
Copy link
Owner

yajra commented Apr 5, 2018

Duplicate of #1688, can't check test the PR yet. Can you please check and confirm a feedback. Will merge if it passes for you.

@vaanholtje
Copy link

vaanholtje commented Apr 5, 2018 •
edited
Loading

@yajra Tested both and both seem to fix the issue think #1688 is a cleaner fix

@cuatao
Copy link
Author

cuatao commented Apr 5, 2018 •
edited
Loading

@yajra Tested #1688, it's ok. I think it is cleaner, so I closed my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cuatao @vaanholtje @yajra