[8.0] Add support for manual setting of filtered count (#1516) #1743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yajra
reviewed
May 17, 2018
src/QueryDataTable.php
Outdated
| * | ||
| * @return int | ||
| */ | ||
| public function filteredCount() |
There was a problem hiding this comment.
Maybe we should promote this function to the abstract class since this will also be used when using Collection?
yajra
changed the title
|
The collection dataTable failed the tests. I think moving the function to the abstract will fix the tests. Thanks! |
yajra
requested changes
May 17, 2018
|
I thought that may be a problem. I'll make the changes. |
patrickwarner
force-pushed
the
filtered-count
branch
from
cdb0483 to
688d2b2
Compare
|
I've moved the function to the abstract class and did a bit of clean-up. Please run the tests again :) |
yajra
approved these changes
May 18, 2018
|
Released on v8.6.0. BTW, if you can spare some more time. Please also submit a PR for docs on how you used this feature at this repo. Thanks a lot! 🍻 |
|
Of course! I will submit documentation within the next couple of days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1516